Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: small speed up to _unpack_variants #148

Merged
merged 3 commits into from
Nov 4, 2022
Merged

feat: small speed up to _unpack_variants #148

merged 3 commits into from
Nov 4, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 4, 2022 •
edited
Loading

This is a 12-14% speed up

@codecov
Copy link

codecov bot commented Nov 4, 2022 •
edited
Loading

Codecov Report

Base: 81.92% // Head: 81.92% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e682ad2) compared to base (ef7d9d4).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head e682ad2 differs from pull request most recent head f339d4f. Consider uploading reports for the commit f339d4f to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   81.92%   81.92%           
=======================================
  Files          27       27           
  Lines        3109     3110    +1     
  Branches      641      641           
=======================================
+ Hits         2547     2548    +1     
- Misses        346      347    +1     
+ Partials      216      215    -1
Impacted Files Coverage Δ
src/dbus_fast/unpack.py 100.00% <100.00%> (ø)
src/dbus_fast/message_bus.py 71.37% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco
Copy link
Member Author

bdraco commented Nov 4, 2022

Tested in production 👍

@bdraco bdraco marked this pull request as ready for review November 4, 2022 10:41
@bdraco bdraco merged commit ef7acdc into main Nov 4, 2022
@bdraco bdraco deleted the unpack_speed branch November 4, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco